fix(slack): publish Home view through the initialized adapter#665
Merged
Conversation
`event.adapter` from webhook-dispatched events is a fresh adapter with no `@slack/web-api` client, so `publishHomeView` threw 'Cannot read properties of undefined (reading client)'. Pass the registered (initialized) adapter via SlackAppHomeDeps and use it for publishing; keep event.adapter as a fallback.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #653/#663. Prod logs showed the Home publish failing with
Cannot read properties of undefined (reading 'client')—event.adapterfrom webhook-dispatched Slack events is a separate, uninitialized adapter instance (no@slack/web-apiclient), sopublishHomeViewblew up. Pass the registered/initialized adapter throughSlackAppHomeDeps.adapterand use it forpublishHomeView;event.adapterstays as a fallback. Tests/build/typecheck green.🤖 Generated with Claude Code