fix(slack): surface the real Home-view error + minimal fallback#663
Merged
Conversation
…ck to a minimal view
The Home-tab publish was failing with an unhelpful '{}' log (pino didn't
serialize the Slack WebAPIPlatformError). Extract message + .data, and on
failure publish a plain text-only home view so the user isn't stuck on the
stale cached one.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #653. The App Home publish was failing in prod with an unhelpful
{"error":{}}log line — pino doesn't serialize a SlackWebAPIPlatformErrorlogged under theerrorkey. This extractserror.message+ the Slack.datapayload so we can see whatviews.publishis actually rejecting, and — so the user isn't left staring at the stale cached view — falls back to publishing a plain text-only home view if the rich one is rejected.Tests: +1 (fallback path), 10 total green; build + typecheck clean.
🤖 Generated with Claude Code