fix(ci): restore owletto-* image names so prod can pull them#512
Merged
Conversation
PR #499 renamed npm packages to @lobu/connector-worker / @lobu/embeddings, which is intentional. As a side-effect it also renamed the docker image push targets to ghcr.io/lobu-ai/connector-worker and lobu-ai/embeddings — but neither the chart helpers (which compute names as ghcr.io/lobu-ai/owletto-{worker,embeddings} from image.repository) nor Flux's image-automation policies/repositories were updated. Result: every Helm upgrade since #499 has been failing with ImagePullBackOff on worker + embeddings, then timing out and rolling back. Currently observed in summaries-prod with two app pods sharing one RWO PVC because the rollback can't fully complete. Surgical revert: keep the npm package renames (those publish to npm and that's their job), restore the docker image names to the form the chart and Flux expect.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-actions
Bot
added
the
triage:needs-human
Contributor
|
Triage decision: needs-human Reasons:
Next: Assigned to @buremba for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the docker image names for worker and embeddings that PR #499 inadvertently broke. Chart and Flux image-automation expect `owletto-worker` and `owletto-embeddings`; #499 changed only the build env vars to `connector-worker` and `embeddings` to match the new npm package names, leaving the chart and Flux pointing at images that no longer exist.
What broke
Result: every Helm upgrade since #499 fails (ImagePullBackOff on worker + embeddings → 15-min Helm timeout → rollback → loop). Currently observed in summaries-prod, blocking the workspaces PVC rollout from #507/#509.
Why revert here vs. update the chart
The npm package renames (`@lobu/connector-worker`, `@lobu/embeddings`) are intentional — those publish to npm and the rename is appropriate. Docker image names don't have to match npm package names. Reverting just the docker image names is a 4-line change with no chart/automation surface area; the alternative (rename chart helpers + image policies + image repositories + chart version bump + parent submodule bump) is much wider and re-tags an active prod registry.
Test plan