chore: rename packages#499
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…install fix Pulls in lobu-ai/owletto#61, which updates the OpenClaw install target string to match the renamed @lobu/openclaw-plugin package. Required for packages/server/src/utils/__tests__/mcp-install-targets.test.ts.
8d96f03 to
efa979b
Compare
Previously deprecateRenamedPackages only marked the just-published version as deprecated; anyone pinned to an older version (e.g. @lobu/owletto-sdk@1.5.0) never saw the rename notice. Switch to 'npm deprecate <pkg>@*' so the deprecation message lands on every existing version. Also drop the dir argument since we no longer need to derive a specific version, and replace isVersionPublished with a simpler isPackagePublished existence check.
Contributor
|
Triage decision: needs-human Reasons:
Next: Assigned to @buremba for manual review due to policy file modifications |
This was referenced May 4, 2026
buremba
added a commit
that referenced
this pull request
May 4, 2026
PR #499 renamed npm packages to @lobu/connector-worker / @lobu/embeddings, which is intentional. As a side-effect it also renamed the docker image push targets to ghcr.io/lobu-ai/connector-worker and lobu-ai/embeddings — but neither the chart helpers (which compute names as ghcr.io/lobu-ai/owletto-{worker,embeddings} from image.repository) nor Flux's image-automation policies/repositories were updated. Result: every Helm upgrade since #499 has been failing with ImagePullBackOff on worker + embeddings, then timing out and rolling back. Currently observed in summaries-prod with two app pods sharing one RWO PVC because the rollback can't fully complete. Surgical revert: keep the npm package renames (those publish to npm and that's their job), restore the docker image names to the form the chart and Flux expect.
buremba
added a commit
that referenced
this pull request
May 4, 2026
…efactor Squash-rebase of PR #506 onto current main (post #499 package rename owletto-backend → server). Combines the original 7-commit history into one because the rename touched every file in the diff. What changed: - ChatInstanceManager reads/writes agent_connections directly via AgentConnectionStore. Drops the parallel chat_connections table + ChatConnectionStore shim. One source of truth. - Connection secrets live as secret:// refs inside the row's config JSON, resolved at runtime through SecretStoreRegistry. Same model as every other secret category — pluggable to AWS Secrets Manager / Vault / k8s without per-platform code paths. - normalizeConfigForStorage moves plaintext secrets into the registry via secretStore.put('connections/<id>/<field>') before save. Idempotent (already-ref values pass through). - resolveConfigForRuntime materializes refs back to values inside startInstance, throws on unresolvable refs. - removeConnection cascades deleteSecretsByPrefix in safe order (history → secrets → row); addConnection rollback uses the same order. - updateConnection's needsRestart resolves previous refs before comparing against caller plaintext, so idempotent lobu-apply re-runs don't trip spurious restarts. - Migration: copies any chat_connections rows into agent_connections (filtering NULL template_agent_id orphans) before DROP. Embedded PGlite path mirrors the same copy+drop wrapped in a pg_tables existence check so fresh installs skip cleanly. - agent-routes.ts: no-manager fallback writes return 503 instead of persisting plaintext directly into agent_connections.config. - postgres-stores.ts: stops encrypting writes; persists config JSON as-is. decryptLegacyEncryptedConfig fallback keeps any pre-existing enc:v1: rows decryptable for graceful transition. - platform.ts: getConnectionStore() added to CoreServices interface. - Bundled small fixes: Telegram non-fatal setWebhook, http-proxy early error handlers, embedded-deployment env hygiene, core-services LOBU_PROVIDER_REGISTRY_PATH respect, agent_channel_bindings startup no longer deletes connections on secret resolution failure. - Drive-by typecheck fixes for pre-existing root-tsc errors in agent-worker that blocked the pre-commit hook (unrelated to this PR's scope, but required to land cleanly): - just-bash-bootstrap.ts: cast envRecord to NodeJS.ProcessEnv for execFile's env option (Vite ImportMetaEnv augments ProcessEnv with BASE_URL/MODE/DEV/PROD/SSR fields stripEnv's return type doesn't include). - openclaw/tools.ts: same cast on the spawnHook env return. Verified: - Per-package bun run typecheck exit 0. - Root bunx tsc --noEmit exit 0. - bun test src/gateway/__tests__/ src/lobu — 559 pass / 0 fail.
buremba
added a commit
that referenced
this pull request
May 4, 2026
…efactor Squash-rebase of PR #506 onto current main (post #499 package rename owletto-backend → server). Combines the original 7-commit history into one because the rename touched every file in the diff. What changed: - ChatInstanceManager reads/writes agent_connections directly via AgentConnectionStore. Drops the parallel chat_connections table + ChatConnectionStore shim. One source of truth. - Connection secrets live as secret:// refs inside the row's config JSON, resolved at runtime through SecretStoreRegistry. Same model as every other secret category — pluggable to AWS Secrets Manager / Vault / k8s without per-platform code paths. - normalizeConfigForStorage moves plaintext secrets into the registry via secretStore.put('connections/<id>/<field>') before save. Idempotent (already-ref values pass through). - resolveConfigForRuntime materializes refs back to values inside startInstance, throws on unresolvable refs. - removeConnection cascades deleteSecretsByPrefix in safe order (history → secrets → row); addConnection rollback uses the same order. - updateConnection's needsRestart resolves previous refs before comparing against caller plaintext, so idempotent lobu-apply re-runs don't trip spurious restarts. - Migration: copies any chat_connections rows into agent_connections (filtering NULL template_agent_id orphans) before DROP. Embedded PGlite path mirrors the same copy+drop wrapped in a pg_tables existence check so fresh installs skip cleanly. - agent-routes.ts: no-manager fallback writes return 503 instead of persisting plaintext directly into agent_connections.config. - postgres-stores.ts: stops encrypting writes; persists config JSON as-is. decryptLegacyEncryptedConfig fallback keeps any pre-existing enc:v1: rows decryptable for graceful transition. - platform.ts: getConnectionStore() added to CoreServices interface. - Bundled small fixes: Telegram non-fatal setWebhook, http-proxy early error handlers, embedded-deployment env hygiene, core-services LOBU_PROVIDER_REGISTRY_PATH respect, agent_channel_bindings startup no longer deletes connections on secret resolution failure. - Drive-by typecheck fixes for pre-existing root-tsc errors in agent-worker that blocked the pre-commit hook (unrelated to this PR's scope, but required to land cleanly): - just-bash-bootstrap.ts: cast envRecord to NodeJS.ProcessEnv for execFile's env option (Vite ImportMetaEnv augments ProcessEnv with BASE_URL/MODE/DEV/PROD/SSR fields stripEnv's return type doesn't include). - openclaw/tools.ts: same cast on the spawnHook env return. Verified: - Per-package bun run typecheck exit 0. - Root bunx tsc --noEmit exit 0. - bun test src/gateway/__tests__/ src/lobu — 559 pass / 0 fail.
buremba
added a commit
that referenced
this pull request
May 4, 2026
…efactor (#506) Squash-rebase of PR #506 onto current main (post #499 package rename owletto-backend → server). Combines the original 7-commit history into one because the rename touched every file in the diff. What changed: - ChatInstanceManager reads/writes agent_connections directly via AgentConnectionStore. Drops the parallel chat_connections table + ChatConnectionStore shim. One source of truth. - Connection secrets live as secret:// refs inside the row's config JSON, resolved at runtime through SecretStoreRegistry. Same model as every other secret category — pluggable to AWS Secrets Manager / Vault / k8s without per-platform code paths. - normalizeConfigForStorage moves plaintext secrets into the registry via secretStore.put('connections/<id>/<field>') before save. Idempotent (already-ref values pass through). - resolveConfigForRuntime materializes refs back to values inside startInstance, throws on unresolvable refs. - removeConnection cascades deleteSecretsByPrefix in safe order (history → secrets → row); addConnection rollback uses the same order. - updateConnection's needsRestart resolves previous refs before comparing against caller plaintext, so idempotent lobu-apply re-runs don't trip spurious restarts. - Migration: copies any chat_connections rows into agent_connections (filtering NULL template_agent_id orphans) before DROP. Embedded PGlite path mirrors the same copy+drop wrapped in a pg_tables existence check so fresh installs skip cleanly. - agent-routes.ts: no-manager fallback writes return 503 instead of persisting plaintext directly into agent_connections.config. - postgres-stores.ts: stops encrypting writes; persists config JSON as-is. decryptLegacyEncryptedConfig fallback keeps any pre-existing enc:v1: rows decryptable for graceful transition. - platform.ts: getConnectionStore() added to CoreServices interface. - Bundled small fixes: Telegram non-fatal setWebhook, http-proxy early error handlers, embedded-deployment env hygiene, core-services LOBU_PROVIDER_REGISTRY_PATH respect, agent_channel_bindings startup no longer deletes connections on secret resolution failure. - Drive-by typecheck fixes for pre-existing root-tsc errors in agent-worker that blocked the pre-commit hook (unrelated to this PR's scope, but required to land cleanly): - just-bash-bootstrap.ts: cast envRecord to NodeJS.ProcessEnv for execFile's env option (Vite ImportMetaEnv augments ProcessEnv with BASE_URL/MODE/DEV/PROD/SSR fields stripEnv's return type doesn't include). - openclaw/tools.ts: same cast on the spawnHook env return. Verified: - Per-package bun run typecheck exit 0. - Root bunx tsc --noEmit exit 0. - bun test src/gateway/__tests__/ src/lobu — 559 pass / 0 fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker→agent-worker,owletto-backend→server,owletto-extension→browser-extension, and the web submodule path topackages/web@lobu/connector-sdk,@lobu/connectors,@lobu/connector-worker,@lobu/embeddings, and@lobu/openclaw-plugin@lobu/owletto-*npm names and update publish/release scripts to publish + deprecate themNPM / release notes
scripts/publish-packages.mjsnow publishes the new package names plus the old redirect packages.npm publish.release-please-config.jsonandscripts/bump-version.mjsinclude the newly published packages and redirect packages.Web submodule
Validation
make build-packagesmake clean-workersbun run typecheckbun run typecheck:owlettocd packages/web && bun run buildcd packages/browser-extension && bun run typecheckgit diff --checkgit -C packages/web diff --checknpm pack --dry-run --jsonfor all published packages and old redirect packagesdocker build -f docker/app/Dockerfile --target builder --build-arg SKIP_WEB_BUILD=false -t lobu-app-rename-check .docker build -f docker/worker/Dockerfile --target builder -t lobu-worker-rename-check .docker build -f docker/embeddings-service/Dockerfile --target builder -t lobu-embeddings-rename-check .