fix(ci): include component in title pattern to fix auto-tagging#194
Merged
Conversation
…o-tagging
release-please v4's buildRelease checks:
normalizeComponent(branchName.component) !== normalizeComponent(branchComponent)
and returns early (skips release creation) on mismatch.
branchName.component comes from parsing the merged PR's title.
branchComponent comes from getBranchComponent() which falls through
to getDefaultPackageName() → root package.json name ("lobu-monorepo")
when component/package-name is empty or unset (JS || treats "" as falsy).
Fix: set package-name to "lobu" (controls the expected component) and
include ${component} in the title pattern so the parser can extract it.
Result: titles like "chore(main): release lobu 3.4.4", and the
component check passes ("lobu" === "lobu").
include-component-in-tag remains false, so tags stay as v3.4.4 (no
component suffix).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Apr 16, 2026
Closed
Closed
Closed
3 tasks
buremba
added a commit
that referenced
this pull request
May 19, 2026
Bumps packages/owletto from 970eb500 → 4f7c7571 (origin/main), bringing in the per-agent guardrail toggle + recent trips view (owletto PR #194). Companion to the guardrails runtime work merged in #919 (call sites + secret-scan + forbidden-tools built-ins) and #915 (schema + judge engine + pii-scan). With this bump the guardrails UI ships end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause found by reading release-please source.
buildRelease()instrategies/base.tsdoes a hardreturn;(not just a warning) when PR title component doesn't match the configured component. Previous fixes (#186, #188, #190, #192) addressed symptoms but not the actual check.The fix:
package-name: "lobu"→ controlsgetBranchComponent()return value${component}inpull-request-title-pattern→ parser can extract component from titlechore(main): release lobu 3.4.4, component check passesinclude-component-in-tag: falsestays, so tags remainv3.4.4.Test plan