chore(examples): drop dead funnel-form connector from lobu-crm#1107
Conversation
The funnel-form connector polled https://lobu.ai/api/demo-requests, which returns 404 — there is no demo-request form feeding it, so the connection produced zero events while polling a dead endpoint every 15 min. Remove the connector, its connection, and the README references; the other connections (GitHub, X, HN, competitor changelogs) are real and stay.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes the funnel-form connector implementation and its wiring from the lobu-crm example. The connector file is deleted entirely, all configuration references are removed, and the README is updated to describe only the remaining agent functionality. ChangesConnector removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…1108) Restores the connectorFromFile showcase the example lost when the dead funnel-form connector was removed (#1107) — but with a connector that actually works. Polls the public npm download-counts API (api.npmjs.org, no auth) for @lobu/cli and emits one event per new weekly period, deduped via a typed rolling checkpoint of seen period-end dates. Weekly npm pulls are a real top-of-funnel adoption signal, so it sits naturally next to the stars/mentions/HN connections. Verified end-to-end against the live endpoint: first sync emits one event (954 downloads, 2026-05-20 → 2026-05-26); re-sync with the checkpoint dedups to zero.
What
Removes the
funnel-formcustom connector + itsfunnel-form-submissionsconnection from theexamples/lobu-crmreference project, plus the README references.Why
The connector polled
https://lobu.ai/api/demo-requests, which returns 404 — there is no demo-request form on the landing page feeding it (grep found no such route or form). So the connection sat in the live lobu-crm org polling a dead endpoint every 15 minutes and produced zero events. Its only real purpose was to demonstrateconnectorFromFile/ConnectorRuntime<Checkpoint, Config>in the example; with no live data behind it, it's dead weight that shows up as an "Installed" connector in the cloud connectors UI with nothing to show.The other connections in the example (GitHub, X, Hacker News, competitor changelogs) are real and unchanged.
Diff
lobu.config.ts: dropconnectorFromFileimport +FunnelFormConnectortype import, thefunnel_form_submissionsConnconnection, and the now-emptyconnectors: [...]array (connectors?is optional indefineConfig).funnel-form.connector.ts.README.md: drop the demo-form mention + the two file references.Verification
tsc --noEmit+biome checkpass.grepconfirms no remainingfunnel-form/connectorFromFile/demo-requestsreferences in the example.landing-snippets.jsonembeds a separate hand-authored "sales" agent example, not this config.Follow-up (not in this PR)
The live lobu-crm cloud org still has the installed connector + connection —
lobu applywon't prune them (connections are never in the delete set; connector prune needs globalprune: true). Those need a direct delete via the admin API / web UI.Summary by CodeRabbit
Documentation
Chores