Skip to content

chore(examples): drop dead funnel-form connector from lobu-crm#1107

Merged
buremba merged 1 commit into
mainfrom
feat/rm-funnel-form
May 28, 2026
Merged

chore(examples): drop dead funnel-form connector from lobu-crm#1107
buremba merged 1 commit into
mainfrom
feat/rm-funnel-form

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 28, 2026

What

Removes the funnel-form custom connector + its funnel-form-submissions connection from the examples/lobu-crm reference project, plus the README references.

Why

The connector polled https://lobu.ai/api/demo-requests, which returns 404 — there is no demo-request form on the landing page feeding it (grep found no such route or form). So the connection sat in the live lobu-crm org polling a dead endpoint every 15 minutes and produced zero events. Its only real purpose was to demonstrate connectorFromFile / ConnectorRuntime<Checkpoint, Config> in the example; with no live data behind it, it's dead weight that shows up as an "Installed" connector in the cloud connectors UI with nothing to show.

The other connections in the example (GitHub, X, Hacker News, competitor changelogs) are real and unchanged.

Diff

  • lobu.config.ts: drop connectorFromFile import + FunnelFormConnector type import, the funnel_form_submissionsConn connection, and the now-empty connectors: [...] array (connectors? is optional in defineConfig).
  • Delete funnel-form.connector.ts.
  • README.md: drop the demo-form mention + the two file references.

Verification

  • Pre-commit tsc --noEmit + biome check pass.
  • grep confirms no remaining funnel-form / connectorFromFile / demo-requests references in the example.
  • No effect on landing snippets — landing-snippets.json embeds a separate hand-authored "sales" agent example, not this config.

Follow-up (not in this PR)

The live lobu-crm cloud org still has the installed connector + connection — lobu apply won't prune them (connections are never in the delete set; connector prune needs global prune: true). Those need a direct delete via the admin API / web UI.

Summary by CodeRabbit

  • Documentation

    • Updated funnel CRM example to reflect new capabilities for tracking GitHub stars, X mentions, and HN posts.
  • Chores

    • Removed deprecated connector implementation and associated configuration from the example project.

Review Change Stack

The funnel-form connector polled https://lobu.ai/api/demo-requests, which
returns 404 — there is no demo-request form feeding it, so the connection
produced zero events while polling a dead endpoint every 15 min. Remove the
connector, its connection, and the README references; the other connections
(GitHub, X, HN, competitor changelogs) are real and stay.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f31acab5-7184-48ee-88d2-0690b0d056ac

📥 Commits

Reviewing files that changed from the base of the PR and between 11dcd74 and bb3f6cd.

📒 Files selected for processing (3)
  • examples/lobu-crm/README.md
  • examples/lobu-crm/funnel-form.connector.ts
  • examples/lobu-crm/lobu.config.ts
💤 Files with no reviewable changes (2)
  • examples/lobu-crm/funnel-form.connector.ts
  • examples/lobu-crm/lobu.config.ts

📝 Walkthrough

Walkthrough

This PR removes the funnel-form connector implementation and its wiring from the lobu-crm example. The connector file is deleted entirely, all configuration references are removed, and the README is updated to describe only the remaining agent functionality.

Changes

Connector removal

Layer / File(s) Summary
Remove connector wiring from configuration
examples/lobu-crm/lobu.config.ts
The connectorFromFile import, FunnelFormConnector type import, funnel_form_submissionsConn connection definition, and all references to the ./funnel-form.connector.ts connector in the connectors and connections configuration are removed.
Update README to reflect removal
examples/lobu-crm/README.md
The example description is updated to omit "demo-form submissions" and narrowed to track GitHub stars, X mentions, and Hacker News posts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • lobu-ai/lobu#1048: Adjusts defineConfig connector wiring to support explicit connector registration via connectorFromFile(...) instead of auto-discovery.

Poem

A form once channeled through code,
Now rests where the old days abode,
We trim what's not needed,
By documentation, heeded—
The CRM hops down cleaner road. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: removing a dead funnel-form connector from the lobu-crm example project.
Description check ✅ Passed The description includes What and Why sections with clear context, a detailed Diff section, and Verification steps, but lacks explicit Test plan checkboxes as specified in the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/rm-funnel-form

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@buremba buremba merged commit 7203478 into main May 28, 2026
21 checks passed
@buremba buremba deleted the feat/rm-funnel-form branch May 28, 2026 00:48
buremba added a commit that referenced this pull request May 28, 2026
…1108)

Restores the connectorFromFile showcase the example lost when the dead
funnel-form connector was removed (#1107) — but with a connector that
actually works. Polls the public npm download-counts API (api.npmjs.org,
no auth) for @lobu/cli and emits one event per new weekly period, deduped
via a typed rolling checkpoint of seen period-end dates. Weekly npm pulls
are a real top-of-funnel adoption signal, so it sits naturally next to the
stars/mentions/HN connections.

Verified end-to-end against the live endpoint: first sync emits one event
(954 downloads, 2026-05-20 → 2026-05-26); re-sync with the checkpoint
dedups to zero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants