fix(ci): migrate sdk-e2e fixture to connectorFromFile (unbreak main)#1048
Conversation
…./connectors scan) PR #1043 removed the ./connectors auto-discovery in favor of explicit connectorFromFile(), and swept every examples/*/lobu.config.ts over — but the sdk-e2e gate scaffolds its own hermetic fixture inline in a shell-script heredoc (not in examples/), so the migration missed it. The fixture's local pulse.connector.ts was no longer discovered, so connection "pulse" referenced an uninstalled connector "sdke2e-pulse" → apply halted → main went red. Declare the connector explicitly to match the new API.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe SDK E2E script's generated ChangesE2E Fixture Connector Registration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Why main is red
mainhas been red since #1043 (refactor(cli): explicit connectorFromFile, drop ./connectors scan). That PR removed the./connectorsauto-discovery and migrated everyexamples/*/lobu.config.tsto declare connectors explicitly viaconnectorFromFile(...).But the
sdk-e2egate doesn't useexamples/— it scaffolds its own hermetic fixture inline in ascripts/sdk-e2e.shheredoc (deliberately: a zero-dep, no-network local connector so the gate can assert the full compile→install→spawn→sync→persist path deterministically). Because that fixture lives in a shell script and not the examples tree, the #1043 migration sweep missed it.Result: the fixture's
./connectors/pulse.connector.tswas no longer discovered → connectionpulsereferenced an uninstalled connectorsdke2e-pulse→ apply halted on first failure → thesdk-e2ejob failed onmainand every branch cut from it.Fix
Declare the connector explicitly in the fixture's
defineConfig, mirroring exactly what #1043 did to the examples:E2E (red → green)
Red (pre-fix, on
main):❌ SDK e2e FAILED: auto-apply did not complete (skipped/halted?)— connectorsdke2e-pulsenot installed.Green (this branch,
bash scripts/sdk-e2e.sh, Node 22):Summary by CodeRabbit