Skip to content

chore: bump owletto pointer for notification nav fallback#1102

Merged
buremba merged 1 commit into
mainfrom
feat/notif-nav-fallback
May 27, 2026
Merged

chore: bump owletto pointer for notification nav fallback#1102
buremba merged 1 commit into
mainfrom
feat/notif-nav-fallback

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 27, 2026

Bumps the packages/owletto submodule pointer to pick up owletto#235.

What it fixes

Clicking a notification in the command palette / inbox did nothing for notifications sent without a resource_url — including the lobu-crm watcher notifications Inbound triage, Weekly funnel digest, and the E2E delivery check. Those go through client.notifications.send({ title, body, watcher_source }), which leaves resource_url NULL, and openNotification only navigated if (n.resource_url).

owletto#235 adds a notificationTarget() helper that falls back to the current org's events feed (/{owner}/events) when a notification has no resource_url — the activity view where watcher reactions write their knowledge events. Fixes existing un-linked notifications and all future ones, across every app.

Validation (in owletto#235)

  • new unit test notification-target.test.ts — 5/5 (incl. the null/{owner}/events bug repro)
  • full owletto vitest suite — 164/164
  • tsc --noEmit clean, vite build clean
  • pi code review of the diff: 0 bugs, 0 slop, simplicity 92, risk low

Pointer: 718cc7c236c39bfc (owletto main, #235 merged).

Summary by CodeRabbit

  • Chores
    • Updated the owletto package to a newer version.

Review Change Stack

Brings in owletto#235 — notifications without a resource_url now fall back
to the org events feed instead of dead-clicking in the command palette.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 94012990-d059-4256-a80c-514ef226ec20

📥 Commits

Reviewing files that changed from the base of the PR and between 30ba504 and c5547a0.

📒 Files selected for processing (1)
  • packages/owletto

📝 Walkthrough

Walkthrough

The packages/owletto subproject git reference is updated from commit 718cc7c2 to commit 36c39bfc1, incorporating changes from the upstream owletto submodule into the lobu repository.

Changes

Owletto submodule update

Layer / File(s) Summary
Owletto submodule commit bump
packages/owletto
The subproject reference is advanced to a newer commit SHA, pulling in upstream changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • lobu-ai/lobu#997: Similar subproject pointer bump to a different owletto commit.
  • lobu-ai/lobu#1096: Another packages/owletto submodule reference update to a different commit.
  • lobu-ai/lobu#1095: Contemporaneous pointer-only bump of the same owletto submodule.

Poem

🐰 A hop, a skip, a pointer tweak,
The owletto grows and reaches its peak,
From old commit to brand new hash,
Dependencies dance in a quick submodule dash! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bump owletto pointer for notification nav fallback' accurately summarizes the main change: updating a submodule pointer to fix notification navigation.
Description check ✅ Passed The description covers the key aspects: what was fixed, why it was needed, and validation details. However, it lacks explicit coverage of the required 'Test plan' section from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/notif-nav-fallback

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@buremba
Copy link
Copy Markdown
Member Author

buremba commented May 27, 2026

bug_free 88, simplicity 96, slop 0, bugs 0, 0 blockers

Read diff; typecheck and unit suites passed. [env] integration failed in untouched server tests because embedded Postgres could not create a shared memory segment. Ran cd packages/owletto && bun test src/lib/notification-target.test.ts (5 pass) and confirmed the bumped owletto commit is reachable on origin/main.

Full verdict JSON
{
  "bug_free_confidence": 88,
  "bugs": 0,
  "slop": 0,
  "simplicity": 96,
  "blockers": [],
  "change_type": "fix",
  "behavior_change_risk": "low",
  "tests_adequate": true,
  "suggested_fixes": [],
  "notes": "Read diff; typecheck and unit suites passed. [env] integration failed in untouched server tests because embedded Postgres could not create a shared memory segment. Ran `cd packages/owletto && bun test src/lib/notification-target.test.ts` (5 pass) and confirmed the bumped owletto commit is reachable on origin/main.",
  "categories": {
    "src": 0,
    "tests": 0,
    "docs": 0,
    "config": 0,
    "deps": 2,
    "migrations": 0,
    "ci": 0,
    "generated": 0
  }
}

Local review gate — branch protection can require the pi-review commit status. See docs/REVIEW_SCHEMA.md.

@buremba buremba merged commit 12a7df1 into main May 27, 2026
22 checks passed
@buremba buremba deleted the feat/notif-nav-fallback branch May 27, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants