chore: bump owletto pointer for notification nav fallback#1102
Conversation
Brings in owletto#235 — notifications without a resource_url now fall back to the org events feed instead of dead-clicking in the command palette.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesOwletto submodule update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
bug_free 88, simplicity 96, slop 0, bugs 0, 0 blockers Read diff; typecheck and unit suites passed. [env] integration failed in untouched server tests because embedded Postgres could not create a shared memory segment. Ran Full verdict JSON{
"bug_free_confidence": 88,
"bugs": 0,
"slop": 0,
"simplicity": 96,
"blockers": [],
"change_type": "fix",
"behavior_change_risk": "low",
"tests_adequate": true,
"suggested_fixes": [],
"notes": "Read diff; typecheck and unit suites passed. [env] integration failed in untouched server tests because embedded Postgres could not create a shared memory segment. Ran `cd packages/owletto && bun test src/lib/notification-target.test.ts` (5 pass) and confirmed the bumped owletto commit is reachable on origin/main.",
"categories": {
"src": 0,
"tests": 0,
"docs": 0,
"config": 0,
"deps": 2,
"migrations": 0,
"ci": 0,
"generated": 0
}
}Local review gate — branch protection can require the |
Bumps the
packages/owlettosubmodule pointer to pick up owletto#235.What it fixes
Clicking a notification in the command palette / inbox did nothing for notifications sent without a
resource_url— including the lobu-crm watcher notifications Inbound triage, Weekly funnel digest, and the E2E delivery check. Those go throughclient.notifications.send({ title, body, watcher_source }), which leavesresource_urlNULL, andopenNotificationonly navigatedif (n.resource_url).owletto#235 adds a
notificationTarget()helper that falls back to the current org's events feed (/{owner}/events) when a notification has noresource_url— the activity view where watcher reactions write their knowledge events. Fixes existing un-linked notifications and all future ones, across every app.Validation (in owletto#235)
notification-target.test.ts— 5/5 (incl. thenull→/{owner}/eventsbug repro)tsc --noEmitclean,vite buildcleanPointer:
718cc7c2→36c39bfc(owletto main, #235 merged).Summary by CodeRabbit