Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert logger to Typescript #458

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Dec 27, 2023

No description provided.

Winston can only be default-imported with the esModuleInterop
flag enabled:

```
logger.ts:1:8 - error TS1259: Module '"C:/Users/PC/projs/bot/node_modules/winston/index"' can only be default-imported using the 'esModuleInterop' flag

1 import winston from 'winston';
         ~~~~~~~

  node_modules/winston/index.d.ts:213:1
    213 export = winston;
        ~~~~~~~~~~~~~~~~~
    This module is declared with 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.
```
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great contribution 🚀

@grunch grunch merged commit 604bfb3 into lnp2pBot:main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants