Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel_orders: check created invoices #439

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Oct 16, 2023

Added a new condition to validate the expiration time of orders with the creation time of invoices.

Order will now be deleted if the order has expired and there has been no payment or the payment has been made long ago.

Fixes: #434

@grunch
Copy link
Member

grunch commented Oct 20, 2023

Hi @Mersho thank you for this fix, great job, I just reviewed and it works like a charm, but we have a little problem.

I had to revert a merged typescript PR so this fix need to be done on the original cancel_order.js, can you do it?

Thank you again 🥳

@knocte
Copy link
Contributor

knocte commented Oct 21, 2023

Thanks for the feedback @grunch . If you don't mind, @Mersho will try to fix whatever was wrong with the JS->TS PR first.

@grunch
Copy link
Member

grunch commented Oct 23, 2023

Thanks for the feedback @grunch . If you don't mind, @Mersho will try to fix whatever was wrong with the JS->TS PR first.

great thanks 😃

@knocte
Copy link
Contributor

knocte commented Dec 31, 2023

Thanks for the feedback @grunch . If you don't mind, @Mersho will try to fix whatever was wrong with the JS->TS PR first.

great thanks 😃

Sorry for the big delay, we've been quite busy. In the end we have decided to split the JS->TS PR as per your advice, and the first subPR is here:
#458 , can you review it @grunch ?

@Mersho can you now rebase this PR please?

Added a new condition to validate the expiration time of
orders with the creation time of invoices.

Order will now be deleted if the order has expired and there
has been no payment or the payment has been made long ago.

Fixes: lnp2pBot#434

Co-authored-by: Afshin Arani <[email protected]>
@Mersho Mersho force-pushed the buyerInvoiceOrderFix branch from 24ea5ba to 7ede948 Compare January 2, 2024 08:35
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for this great contribution 🥳

@grunch grunch merged commit 6f65103 into lnp2pBot:main Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timer for BTC buyer(maker) should restart after seller(taker) has sent money to invoice
3 participants