Skip to content

[ADT] DenseMapInfo<unsigned long>::getHashValue - avoid MSVC out of bounds shift warning #96173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RKSimon merged 3 commits into from
Jun 20, 2024
Merged

[ADT] DenseMapInfo<unsigned long>::getHashValue - avoid MSVC out of bounds shift warning #96173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c213d8c
[ADT] DenseMapInfo<unsigned long>::getHashValue - avoid MSVC out of b…
RKSimon Jun 20, 2024
c484ded
Use densemap::detail::mix(Val) instead
RKSimon Jun 20, 2024
ffa04f0
Use densemap::detail::mix(Val) for the unsigned long long case as well
RKSimon Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/include/llvm/ADT/DenseMapInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ template<> struct DenseMapInfo<unsigned long> {
if constexpr (sizeof(Val) == 4)
return DenseMapInfo<unsigned>::getHashValue(Val);
else
return detail::combineHashValue(Val >> 32, Val);
return densemap::detail::mix(Val);
}

static bool isEqual(const unsigned long& LHS, const unsigned long& RHS) {
Expand All @@ -156,7 +156,7 @@ template<> struct DenseMapInfo<unsigned long long> {
static inline unsigned long long getTombstoneKey() { return ~0ULL - 1ULL; }

static unsigned getHashValue(const unsigned long long& Val) {
return detail::combineHashValue(Val >> 32, Val);
return densemap::detail::mix(Val);
}

static bool isEqual(const unsigned long long& LHS,
Expand Down