Skip to content

[llvm-exegesis] Add support for alder lake #88967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boomanaiden154 merged 3 commits into from
Apr 23, 2024
Merged

[llvm-exegesis] Add support for alder lake #88967

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f283b93
[llvm-exegesis] Add support for alder lake
boomanaiden154 Apr 16, 2024
829205a
Address reviewer feedback
boomanaiden154 Apr 20, 2024
856a4d9
Push unsaved changes
boomanaiden154 Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions llvm/lib/Target/X86/X86PfmCounters.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,27 @@ def : PfmCountersBinding<"icelake-server", IceLakePfmCounters>;
def : PfmCountersBinding<"rocketlake", IceLakePfmCounters>;
def : PfmCountersBinding<"tigerlake", IceLakePfmCounters>;

def AlderLakePfmCounters : ProcPfmCounters {
let CycleCounter = UnhaltedCoreCyclesPfmCounter;
let UopsCounter = UopsIssuedPfmCounter;
let IssueCounters = [
PfmIssueCounter<"ADLPPort00", "uops_dispatched_port:port_0">,
PfmIssueCounter<"ADLPPort01", "uops_dispatched_port:port_1">,
PfmIssueCounter<"ADLPPort02", "uops_dispatched_port:port_2_3_10">,
PfmIssueCounter<"ADLPPort03", "uops_dispatched_port:port_2_3_10">,
PfmIssueCounter<"ADLPPort04", "uops_dispatched_port:port_4_9">,
Copy link
Collaborator

@RKSimon RKSimon Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ADLPPort04_09 instead - adding the other ProcResGroup combos to X86SchedAlderlakeP.td shouldn't be a problem.

Copy link
Contributor Author

@boomanaiden154 boomanaiden154 Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe I missed that one along with 1-2 others. I've added in the ones that were missing as well to X86SchedAlderlakeP.td, along with a ADLPPortAny ProcResGroup so that all of the overlapping groups have a super group (I believe that won't cause any issues?).

PfmIssueCounter<"ADLPPort05", "uops_dispatched_port:port_5_11">,
PfmIssueCounter<"ADLPPort06", "uops_dispatched_port:port_6">,
PfmIssueCounter<"ADLPPort07", "uops_dispatched_port:port_7_8">,
PfmIssueCounter<"ADLPPort08", "uops_dispatched_port:port_7_8">,
PfmIssueCounter<"ADLPPort09", "uops_dispatched_port:port_4_9">,
PfmIssueCounter<"ADLPPort10", "uops_dispatched_port:port_2_3_10">,
PfmIssueCounter<"ADLPPort11", "uops_dispatched_port:port_5_11">,
];
let ValidationCounters = DefaultIntelPfmValidationCounters;
}
def : PfmCountersBinding<"alderlake", AlderLakePfmCounters>;

// AMD X86 Counters.
defvar DefaultAMDPfmValidationCounters = [
PfmValidationCounter<InstructionRetired, "RETIRED_INSTRUCTIONS">,
Expand Down