Exclude libc math C++ builtins from compiler-rt Bazel overlay - #208861
Merged
Conversation
zygoloid
requested review from
aaronmondal,
googlewalt,
keith and
rupprecht
as code owners
July 11, 2026 00:08
llvmorg-github-actions
Bot
added
the
bazel
In CMake, addtf3.cpp is only compiled when COMPILER_RT_USE_LIBC_MATH is ON, replacing addtf3.c. In the Bazel overlay, builtins_generic_srcs globbed all lib/builtins/*.cpp without excluding addtf3.cpp, causing compile failures when not using libc math. Assisted-by: Gemini via Antigravity
zygoloid
force-pushed
the
bazel-build-exclude-addtf3-cpp
branch
from
July 13, 2026 19:16
73b10f1 to
71c318f
Compare
dayanruben
pushed a commit
to dayanruben/carbon-lang
that referenced
this pull request
Jul 14, 2026
Fix a few API issues. There's also a newly-added file in compiler-rt that is not supposed to be built by default but is not being excluded properly by a glob. Added a patch to exclude that and sent llvm/llvm-project#208861 upstream.
pedroMVicente
pushed a commit
to pedroMVicente/llvm-project
that referenced
this pull request
Jul 15, 2026
…08861) In CMake, addtf3.cpp is only compiled when COMPILER_RT_USE_LIBC_MATH is ON, replacing addtf3.c. In the Bazel overlay, builtins_generic_srcs globbed all lib/builtins/*.cpp without excluding addtf3.cpp, causing compile failures when not using libc math. Assisted-by: Gemini via Antigravity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CMake, addtf3.cpp is only compiled when COMPILER_RT_USE_LIBC_MATH is ON, replacing addtf3.c. In the Bazel overlay, builtins_generic_srcs globbed all lib/builtins/*.cpp without excluding addtf3.cpp, causing compile failures when not using libc math.
Assisted-by: Gemini via Antigravity