Update to a more recent LLVM. - #7488
Merged
Merged
Conversation
geoffromer
approved these changes
Jul 13, 2026
| Date: Fri, 10 Jul 2026 23:42:00 +0000 | ||
| Subject: [PATCH] Exclude libc math C++ builtins from compiler-rt Bazel overlay | ||
|
|
||
| In CMake, addtf3.cpp is only compiled when COMPILER_RT_USE_LIBC_MATH is ON, |
Contributor
There was a problem hiding this comment.
Would it make sense to cross-reference the upstream issue, or is the convention for the patch file to exactly match the upstream commit description?
Contributor
Author
There was a problem hiding this comment.
As far as I can see, the convention is for the patch to match the upstream change; other patches don't mention the upstream PR.
zygoloid
enabled auto-merge
July 13, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few API issues. There's also a newly-added file in compiler-rt that is not supposed to be built by default but is not being excluded properly by a glob. Added a patch to exclude that and sent llvm/llvm-project#208861 upstream.