Fix UNSUPPORTED added to test in #194502. - #194541
Merged
Merged
Conversation
llvmbot
added
clang
dyung
enabled auto-merge (squash)
April 28, 2026 05:03
Member
|
@llvm/pr-subscribers-clang Author: dyung ChangesThe change in #194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it. Full diff: https://github.com/llvm/llvm-project/pull/194541.diff 1 Files Affected:
diff --git a/clang/test/Driver/modules-driver-import-std.cpp b/clang/test/Driver/modules-driver-import-std.cpp
index 0fc49c1658c5d..394b0dc8d95d3 100644
--- a/clang/test/Driver/modules-driver-import-std.cpp
+++ b/clang/test/Driver/modules-driver-import-std.cpp
@@ -2,7 +2,7 @@
// modules.
// https://github.com/llvm/llvm-project/pull/194475#issuecomment-4331347690
-// UNSUPPORTED: aarch64
+// UNSUPPORTED: target={{.*}}aarch64{{.*}}, {{.*}}arm64{{.*}}
// The standard library modules manifest (libc++.modules.json) is discovered
// relative to the installed C++ standard library runtime libraries
|
Member
|
@llvm/pr-subscribers-clang-driver Author: dyung ChangesThe change in #194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it. Full diff: https://github.com/llvm/llvm-project/pull/194541.diff 1 Files Affected:
diff --git a/clang/test/Driver/modules-driver-import-std.cpp b/clang/test/Driver/modules-driver-import-std.cpp
index 0fc49c1658c5d..394b0dc8d95d3 100644
--- a/clang/test/Driver/modules-driver-import-std.cpp
+++ b/clang/test/Driver/modules-driver-import-std.cpp
@@ -2,7 +2,7 @@
// modules.
// https://github.com/llvm/llvm-project/pull/194475#issuecomment-4331347690
-// UNSUPPORTED: aarch64
+// UNSUPPORTED: target={{.*}}aarch64{{.*}}, {{.*}}arm64{{.*}}
// The standard library modules manifest (libc++.modules.json) is discovered
// relative to the installed C++ standard library runtime libraries
|
Contributor
|
Thank you for fixing this and apologies for the breakage! |
yingopq
pushed a commit
to yingopq/llvm-project
that referenced
this pull request
Apr 29, 2026
The change in llvm#194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it.
KHicketts
pushed a commit
to KHicketts/llvm-project
that referenced
this pull request
Apr 30, 2026
The change in llvm#194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it.