[clang][modules-driver] Fix failing import-std regression test - #194502
Merged
Conversation
See llvm#194475 (comment). This constrains the test to not run on aarch64, where it fails on clang-aarch64-quick and llvm-clang-aarch64-darwin builders.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-driver Author: Naveen Seth Hanig (naveen-seth) ChangesSee #194475 (comment). Full diff: https://github.com/llvm/llvm-project/pull/194502.diff 1 Files Affected:
diff --git a/clang/test/Driver/modules-driver-import-std.cpp b/clang/test/Driver/modules-driver-import-std.cpp
index e2a74df05fdc0..0fc49c1658c5d 100644
--- a/clang/test/Driver/modules-driver-import-std.cpp
+++ b/clang/test/Driver/modules-driver-import-std.cpp
@@ -1,6 +1,9 @@
// Checks that -fmodules-driver correctly handles the import of Standard library
// modules.
+// https://github.com/llvm/llvm-project/pull/194475#issuecomment-4331347690
+// UNSUPPORTED: aarch64
+
// The standard library modules manifest (libc++.modules.json) is discovered
// relative to the installed C++ standard library runtime libraries
// We need to create them in order for Clang to find the manifest.
|
Member
|
@llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) ChangesSee #194475 (comment). Full diff: https://github.com/llvm/llvm-project/pull/194502.diff 1 Files Affected:
diff --git a/clang/test/Driver/modules-driver-import-std.cpp b/clang/test/Driver/modules-driver-import-std.cpp
index e2a74df05fdc0..0fc49c1658c5d 100644
--- a/clang/test/Driver/modules-driver-import-std.cpp
+++ b/clang/test/Driver/modules-driver-import-std.cpp
@@ -1,6 +1,9 @@
// Checks that -fmodules-driver correctly handles the import of Standard library
// modules.
+// https://github.com/llvm/llvm-project/pull/194475#issuecomment-4331347690
+// UNSUPPORTED: aarch64
+
// The standard library modules manifest (libc++.modules.json) is discovered
// relative to the installed C++ standard library runtime libraries
// We need to create them in order for Clang to find the manifest.
|
dyung
added a commit
that referenced
this pull request
Apr 28, 2026
yingopq
pushed a commit
to yingopq/llvm-project
that referenced
this pull request
Apr 29, 2026
…194502) See llvm#194475 (comment). This constrains the test to not run on aarch64, where it fails on `clang-aarch64-quick` and `llvm-clang-aarch64-darwin` builders. The failing builders don't show any output, and the test will be re-enabled for aarch64 in a later follow-up. Co-authored-by: Naveen Seth Hanig <naveen.hanig@oulook.com>
yingopq
pushed a commit
to yingopq/llvm-project
that referenced
this pull request
Apr 29, 2026
The change in llvm#194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it.
KHicketts
pushed a commit
to KHicketts/llvm-project
that referenced
this pull request
Apr 30, 2026
…194502) See llvm#194475 (comment). This constrains the test to not run on aarch64, where it fails on `clang-aarch64-quick` and `llvm-clang-aarch64-darwin` builders. The failing builders don't show any output, and the test will be re-enabled for aarch64 in a later follow-up. Co-authored-by: Naveen Seth Hanig <naveen.hanig@oulook.com>
KHicketts
pushed a commit
to KHicketts/llvm-project
that referenced
this pull request
Apr 30, 2026
The change in llvm#194502 attempted to mark the test as UNSUPPORTED for AArch64, but it didn't work because it wasn't specified correctly. This fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #194475 (comment).
This constrains the test to not run on aarch64, where it fails on
clang-aarch64-quickandllvm-clang-aarch64-darwinbuilders.The failing builders don't show any output, and the test will be re-enabled for aarch64 in a later follow-up.