release/22.x: [OpenMP][omptest] Improve CMake and address review comments (#159416)#183775
Closed
llvmbot wants to merge 2 commits intollvm:release/22.xfrom
Closed
release/22.x: [OpenMP][omptest] Improve CMake and address review comments (#159416)#183775llvmbot wants to merge 2 commits intollvm:release/22.xfrom
llvmbot wants to merge 2 commits intollvm:release/22.xfrom
Conversation
) Avoid explicit ABI breaking check deactivation Replace whole-archive linking with dedicated build of GoogleTest lib Addresses remaining post-merge review comments of llvm#154786 (cherry picked from commit d5fea7e)
Fix visibility of target properties: * INCLUDE_DIRECTORIES * COMPILE_DEFINITIONS implicitly pulled in from `default_gtest`. Fixes: llvm#159416 (cherry picked from commit 696b91a)
Member
Author
llvmbot
added
openmp:libomp
mstorsjo
changed the title
github-project-automation
bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport d5fea7e 696b91a
Requested by: @mstorsjo