[OpenMP][omptest] Fix CMake target properties#176802
Merged
Conversation
Fix visibility of target properties: * INCLUDE_DIRECTORIES * COMPILE_DEFINITIONS implicitly pulled in from default_gtest. Fixes: llvm#159416
llvmbot
added
openmp:libomp
BStott6
pushed a commit
to BStott6/llvm-project
that referenced
this pull request
Jan 22, 2026
Fix visibility of target properties: * INCLUDE_DIRECTORIES * COMPILE_DEFINITIONS implicitly pulled in from `default_gtest`. Fixes: llvm#159416
Collaborator
|
This got the flang-libcxx back to green after a very long time being red. Thanks for all your effort in this area! |
dyung
pushed a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix visibility of target properties:
implicitly pulled in from
default_gtest.Fixes: #159416