[runtimes] Share doxygen handling with LLVM#176948
Merged
Meinersbur merged 3 commits intollvm:mainfrom Jan 21, 2026
Merged
Conversation
Share doxygen handling
Meinersbur
requested review from
boomanaiden154,
ldionne,
llvm-beanz,
petrhosek and
tstellar
petrhosek
reviewed
Jan 21, 2026
Co-authored-by: Petr Hosek <phosek@google.com>
petrhosek
reviewed
Jan 21, 2026
petrhosek
approved these changes
Jan 21, 2026
Member
petrhosek
left a comment
petrhosek
left a comment
There was a problem hiding this comment.
There's also a lot of duplicated (copy-pasted?) code to setup Doxygen for each subproject:
bolt/docs/CMakeLists.txtclang-tools-extra/docs/CMakeLists.txtclang/docs/CMakeLists.txtflang/docs/CMakeLists.txtllvm/docs/CMakeLists.txtmlir/docs/CMakeLists.txtopenmp/docs/CMakeLists.txtpolly/docs/CMakeLists.txt
We should look into extracting that logic into a function in this module, but that can be done in follow up changes.
Co-authored-by: Petr Hosek <phosek@google.com>
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/17017 Here is the relevant piece of the build log for the reference |
Harrish92
pushed a commit
to Harrish92/llvm-project
that referenced
this pull request
Jan 23, 2026
Hoist handling of Doxygen into the top-level cmake/ directory so it can be shared between LLVM and RUNTIMES and a default/standalone runtimes build can support building Doxygen documentation as well. The openmp subproject currently supports doxygen documentation using an `LLVM_ENABLE_PROJECTS=openmp` build, but not with `LLVM_ENABLE_RUNTIMES=openmp` because of this missing boilerplate code in the runtimes build. This is a step towards removing the `LLVM_ENABLE_PROJECTS=openmp` build mode which was deprecated (llvm#124014) and already scheduled to be removed in LLVM 21 (llvm#136314). Eventual removal is planned with llvm#176950. Hoisting CMake code for shared use with runtimes has been done before in e.g. llvm#84641, 7017e6c, 44e3365, 7017e6c --------- Co-authored-by: Petr Hosek <phosek@google.com>
Harrish92
pushed a commit
to Harrish92/llvm-project
that referenced
this pull request
Jan 24, 2026
Hoist handling of Doxygen into the top-level cmake/ directory so it can be shared between LLVM and RUNTIMES and a default/standalone runtimes build can support building Doxygen documentation as well. The openmp subproject currently supports doxygen documentation using an `LLVM_ENABLE_PROJECTS=openmp` build, but not with `LLVM_ENABLE_RUNTIMES=openmp` because of this missing boilerplate code in the runtimes build. This is a step towards removing the `LLVM_ENABLE_PROJECTS=openmp` build mode which was deprecated (llvm#124014) and already scheduled to be removed in LLVM 21 (llvm#136314). Eventual removal is planned with llvm#176950. Hoisting CMake code for shared use with runtimes has been done before in e.g. llvm#84641, 7017e6c, 44e3365, 7017e6c --------- Co-authored-by: Petr Hosek <phosek@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist handling of Doxygen into the top-level cmake/ directory so it can be shared between LLVM and RUNTIMES so a default/standalone runtimes build can support building Doxygen documentation as well.
The openmp subproject currently supports doxygen documentation using an
LLVM_ENABLE_PROJECTS=openmpbuild, but not withLLVM_ENABLE_RUNTIMES=openmpbecause of this missing boilerplate code in the runtimes build. This is a step towards removing theLLVM_ENABLE_PROJECTS=openmpbuild mode which was deprecated (#124014) and already scheduled to be removed in LLVM 21 (#136314). Eventual removal is planned with #176950.Hoisting CMake code for shared use with runtimes has been done before in e.g. #84641, 7017e6c, 44e3365, 7017e6c