Skip to content

[X86] masked_gather.ll - add mask from scalar value and test coverage for "fast-gather" avx2 targets#175736

Merged
RKSimon merged 1 commit intollvm:mainfrom
RKSimon:x86-gather-mask-scalar-tests
Jan 13, 2026
Merged

[X86] masked_gather.ll - add mask from scalar value and test coverage for "fast-gather" avx2 targets#175736
RKSimon merged 1 commit intollvm:mainfrom
RKSimon:x86-gather-mask-scalar-tests

Conversation

@RKSimon
Copy link
Collaborator

@RKSimon RKSimon commented Jan 13, 2026

Test coverage to help #175385

@RKSimon RKSimon enabled auto-merge (squash) January 13, 2026 10:28
@github-actions
Copy link

⚠️ undef deprecator found issues in your code. ⚠️

You can test this locally with the following command:
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/test/CodeGen/X86/masked_gather.ll

The following files introduce new uses of undef:

  • llvm/test/CodeGen/X86/masked_gather.ll

Undef is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields undef. You should use poison values for placeholders instead.

In tests, avoid using undef and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:

define void @fn() {
  ...
  br i1 undef, ...
}

Please use the following instead:

define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}

Please refer to the Undefined Behavior Manual for more information.

@RKSimon RKSimon merged commit 5cbd2f1 into llvm:main Jan 13, 2026
10 of 12 checks passed
@RKSimon RKSimon deleted the x86-gather-mask-scalar-tests branch January 13, 2026 11:01
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant