[Headers][X86] Allow basic AVX512 predicate ops to be used in constexpr #159998
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
RKSimon
left a comment
RKSimon
left a comment
There was a problem hiding this comment.
Add the other mask logic / kadd variants to the patch as well.
_kand_mask16 is an alias of _mm512_kand. Although they are semantically identical, the existing test suite contains a dedicated set of tests for _kand_mask16. This commit follows that convention by adding the same constexpr test case for completeness.
Some comments in the constexpr test suite were a bit too verbose. This commit removes them to keep the code concise.
fennecJ
force-pushed
the
AVX512_Predicate_ConstExpr
branch
from
5335591 to
ff71edf
Compare
|
Cheers, thanks for the review! |
|
@fennecJ Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
3 participants
Fix #158646