Skip to content

Static_cast std::size_t to build flang_rt in 32-bit. #149529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Static_cast std::size_t to build flang_rt in 32-bit. #149529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3182a3b
Static_cast std::size_t to build flang_rt in 32-bit.
DanielCChen Jul 18, 2025
bc1f8bc
Change to auto to address review comments.
DanielCChen Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flang-rt/lib/runtime/descriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ RT_API_ATTRS void Descriptor::Establish(int characterKind,
RT_API_ATTRS void Descriptor::Establish(const typeInfo::DerivedType &dt,
void *p, int rank, const SubscriptValue *extent,
ISO::CFI_attribute_t attribute) {
std::size_t elementBytes{dt.sizeInBytes()};
std::size_t elementBytes{static_cast<std::size_t>(dt.sizeInBytes())};
Copy link
Contributor

@klausler klausler Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a stylistic point, I usually use auto for declarations initialized with casts, since the type is obvious and doesn't need to appear twice.

ISO::EstablishDescriptor(
&raw_, p, attribute, CFI_type_struct, elementBytes, rank, extent);
if (elementBytes == 0) {
Expand Down
Loading