Static_cast std::size_t to build flang_rt in 32-bit. #149529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausler
approved these changes
Jul 18, 2025
flang-rt/lib/runtime/descriptor.cpp
Outdated
| void *p, int rank, const SubscriptValue *extent, | ||
| ISO::CFI_attribute_t attribute) { | ||
| std::size_t elementBytes{dt.sizeInBytes()}; | ||
| std::size_t elementBytes{static_cast<std::size_t>(dt.sizeInBytes())}; |
There was a problem hiding this comment.
As a stylistic point, I usually use auto for declarations initialized with casts, since the type is obvious and doesn't need to appear twice.
mdfazlay
pushed a commit
to mdfazlay/llvm-project
that referenced
this pull request
Jul 18, 2025
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.