-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[utils] Add a script to update regclass numbers in MIR tests #142761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There aren't so many MIR tests that contain this kind of comment (I counted only 40). Why don't just use |
This is a different kind of update. It is not just updating CHECK lines, it is also updating the source lines, like (example from #142359): - INLINEASM &"; def $0", 1 /* sideeffect attdialect */, 1966090 /* regdef:VGPR_32 */, def $vgpr0
+ INLINEASM &"; def $0", 1 /* sideeffect attdialect */, 2228234 /* regdef:VGPR_32 */, def $vgpr0 |
|
I agree with @arsenm here #142359 (comment) While this script may be useful, it doesn't guarantee the tests don't rot over time. Unless we have an automated way to update them, that is. |
Me too, and I would happily remove this script when that suggestion is implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better than nothing
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/17416 Here is the relevant piece of the build log for the reference |
No description provided.