Remove gaie#145
Merged
Merged
Conversation
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Collaborator
Author
|
This should also fix #121. |
jgchn
reviewed
Oct 21, 2025
jgchn
left a comment
jgchn
left a comment
Collaborator
There was a problem hiding this comment.
Please also update chart minor version
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
Signed-off-by: Michael Kalantar <kalantar@us.ibm.com>
jgchn
reviewed
Oct 23, 2025
Collaborator
|
/lgtm |
github-actions
Bot
added
the
lgtm
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove gaie components (epp/inferencepool). None of the llm-d guides use ms for deploying gaie. There is an upstream chart defined here: https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/config/charts/inferencepool (released versions at oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool) that we would basically be copying if we maintained these pieces.
Also removes creation of HTTPRoute but documents how to do this. HTTPRoutes are really between the gateway and gaie components. There are many ways to create them. We find that except for the simplest cases, users redefine them. An
extraObjectcan be used to include them if desired.Fixes #135.
This is a breaking change.