fix: Implement missing run_moderation method in PromptGuardSafetyImpl#3101
Merged
ashwinb merged 1 commit intollamastack:mainfrom Aug 12, 2025
Conversation
nathan-weinberg
approved these changes
Aug 12, 2025
Contributor
nathan-weinberg
left a comment
There was a problem hiding this comment.
Strange as pre-commit was passing in #2678 which was the last PR to modify this file
Thanks for the fix!
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
28a1cce to
eef61e2
Compare
Contributor
|
cc @slekkala1 |
Contributor
|
Hey @Elbehery! I pulled from main, did rebase on my branch and still have this issue: |
Contributor
|
Alright, it works now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses an issue where
PromptGuardSafetyImplwas an incomplete implementation of an abstract class. The class was missing the required run_moderation method from its parent interface.Currently, running
pre-commitlocally fails with the error below.This PR fixes the issue as follows