AudioResampler: initialize frame_.samples_per_channel_ #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Contributor
Author
|
I'm unclear why #722 made a change at a higher level of the stack in NativeAudioSink rather than fixing it here. Zed calls AudioResampler::remix_and_resample directly, so switching to this repository's main branch broke audio playback in Zed. |
22 tasks
Contributor
Author
|
@xianshijing-lk could you take a look at this? Zed panics on livekit's main branch without this one line change. |
Contributor
Author
|
Ping @xianshijing-lk, could you take a look at this one line fix? |
xianshijing-lk
approved these changes
Dec 4, 2025
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
lgtm, that is definitely the right thing to do
Contributor
|
I just landed it. Sorry for missing the email notification. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for the same reason as
b776e64 (#722):
A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.