Fix empty audio frames after resample #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RemixAndResample` will not initialize this field, causing the slice's length to be computed to zero.
ladvoc
changed the title
davidzhao
approved these changes
Oct 3, 2025
Merged
Merged
Be-ing
added a commit
to Be-ing/rust-sdks
that referenced
this pull request
Nov 4, 2025
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Be-ing
added a commit
to Be-ing/rust-sdks
that referenced
this pull request
Nov 4, 2025
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Be-ing
added a commit
to Be-ing/rust-sdks
that referenced
this pull request
Nov 12, 2025
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Be-ing
added a commit
to Be-ing/rust-sdks
that referenced
this pull request
Nov 20, 2025
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Be-ing
added a commit
to Be-ing/rust-sdks
that referenced
this pull request
Dec 1, 2025
This change is needed for the same reason as b776e64 (livekit#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
xianshijing-lk
pushed a commit
that referenced
this pull request
Dec 4, 2025
This change is needed for the same reason as b776e64 (#722): A change in the resampler API introduced in libwebrtc m137 caused the output frame's samples_per_channel_ property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting in NativeAudioStream yielding audio frames without any sample data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in the resampler API introduced in libwebrtc m137 caused the output frame's
samples_per_channel_property to remain uninitialized. As a result, the length of the output slice was always calculated as zero, resulting inNativeAudioStreamyielding audio frames without any sample data.Note: This issue only occurs when resampling is required (i.e., when the sample rate or number of channels used to create the
NativeAudioStreamdoes not match the source).