SIP media encryption setting. #892
Open
+1,118
−917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Nov 25, 2024
🦋 Changeset detectedLatest commit: b656ab0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
biglittlebigben
approved these changes
Dec 9, 2024
protobufs/livekit_sip.proto
Outdated
| @@ -154,7 +160,8 @@ message SIPTrunkInfo { | |||
| // User-defined metadata for the Trunk. | |||
| string metadata = 12; | |||
|
|
|||
| // NEXT ID: 15 | |||
| SIPMediaEncryption media_encryption = 15; | |||
There was a problem hiding this comment.
Isn't SIPTrunkInfo deprecated? If so, do we want to add new options to it?
There was a problem hiding this comment.
Oops! Good catch! Fixed.
dennwc
force-pushed
the
sip-srtp
branch
2 times, most recently
from
9f5d5a1 to
04055a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SIP media encryption setting to support SRTP. Note that the default is to require encryption if TLS transport is used.
Requires #891.