Add useTranscription hook #1109
Conversation
🦋 Changeset detectedLatest commit: 6a41f3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| * ``` | ||
| */ | ||
| export function useTranscriptions(opts?: UseTranscriptionsOptions) { | ||
| const { participantIdentities, trackSids } = opts ?? {}; |
There was a problem hiding this comment.
doesn't adding these options expose an easy trap where you have
const agentTranscriptions = useTranscriptions({ participantIdentities: ['agent'] });
and
const userTranscriptions = useTranscriptions({ participantIdentities: ['user'] });
in two different locations and then they conflict on useTextStream which can only be used once?
There was a problem hiding this comment.
the components implementation creates a registered handler cache that makes it possible to reuse streams across the app without running into that limitation
There was a problem hiding this comment.
ah ok that works. i do still think we should just make it easy for anyone to register multiple handlers but it's not a blocker to this PR
| * ``` | ||
| */ | ||
| export function useTranscriptions(opts?: UseTranscriptionsOptions) { | ||
| const { participantIdentities, trackSids } = opts ?? {}; |
There was a problem hiding this comment.
ah ok that works. i do still think we should just make it easy for anyone to register multiple handlers but it's not a blocker to this PR
bcherry
left a comment
bcherry
left a comment
There was a problem hiding this comment.
should this also get adopted by useVoiceAssistant?
with filtering based on participant identites and track ids.