Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show error dialog when broadcast stops without error (Obj-C bridge) #519

Merged
merged 9 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
put
bcherry committed Dec 4, 2024
commit 7ecde2e992fede219b39b4e3bfc2975c50cf3815
8 changes: 8 additions & 0 deletions Sources/LiveKit/Broadcast/Uploader/LKSampleHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ open class LKSampleHandler: RPBroadcastSampleHandler {
openConnection()
}

override public func broadcastPaused() {
// User has requested to pause the broadcast. Samples will stop being delivered.
}

override public func broadcastResumed() {
// User has requested to resume the broadcast. Samples delivery will resume.
}

override public func broadcastFinished() {
// User has requested to finish the broadcast.
DarwinNotificationCenter.shared.postNotification(.broadcastStopped)
Expand Down