Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show error dialog when broadcast stops without error (Obj-C bridge) #519

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Dec 4, 2024

This is an alternative to #517 that uses the same Objective-C bridge as used in Telegram, instead of some selector and IMP casting magic in Swift

@bcherry bcherry requested a review from hiroshihorie December 4, 2024 04:14
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@bcherry bcherry merged commit 81a80c9 into main Dec 4, 2024
7 of 12 checks passed
@bcherry bcherry deleted the bcherry/broadcast-objc-helper branch December 4, 2024 17:53
@hiroshihorie
Copy link
Member

I had a Mac catalyst fix commit which i forgot to push but no prob. Will make another pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants