Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track processor blips when restarting tracks #842

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 18, 2023

Only works with processors with this PR livekit/track-processors-js#11

supersedes #739

@burzomir thank you for all the investigations you did around this, could you test that combination (this branch and the processor main branch) to see if it solves your use case?

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: d5c8d6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao August 18, 2023 15:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 75.89 KB (+0.07% 🔺)
dist/livekit-client.umd.js 81.25 KB (+0.07% 🔺)

@burzomir
Copy link
Contributor

Thanks, @lukasIO, but it doesn't work at all now. LocalVideoTrack is displayed as a black video element; other participants no longer receive pictures. What I do is:

await camera.setProcessor(blurProcessor, true)
await camera.restartTrack({ facingMode: 'user' })

I'll try to create an example app later.

@lukasIO
Copy link
Contributor Author

lukasIO commented Aug 21, 2023

@burzomir are you using track processors with the PR that I linked or the npm version?

edit: hm, after updating chrome it seems to constantly lose the webgl context. will have to investigate why.

edit2: works as expected in chrome canary, so I suspect it's a bug in chrome (I'm running 116.0.5845.96).

@burzomir
Copy link
Contributor

@lukasIO I rechecked, and it seems to do the trick. I tested it in a simple example app I created (setProcessor and then restart), and it worked without issues using BackgroundBlur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants