Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to simulate subscriber-bandwidth #835

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

davidzhao
Copy link
Member

By using room.simulateScenario('subscriber-bandwidth', bitrate), one could override server-side bandwidth estimator with set bandwidth.

This can be used to test application behavior when congested or to disable congestion control entirely (by setting bandwidth to 100Mbps)

By using `room.simulateScenario('subscriber-bandwidth', bitrate)`,
one could override server-side bandwidth estimator with set bandwidth.

This can be used to test application behavior when congested or
to disable congestion control entirely (by setting bandwidth to 100Mbps)
@davidzhao davidzhao requested review from boks1971 and lukasIO August 13, 2023 22:54
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2023

🦋 Changeset detected

Latest commit: 403c6b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 75.73 KB (+0.1% 🔺)
dist/livekit-client.umd.js 81.08 KB (+0.09% 🔺)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Is there an (easy) way to reset the behaviour in order to re-enable server side bandwidth estimation?

@davidzhao
Copy link
Member Author

lgtm! Is there an (easy) way to reset the behaviour in order to re-enable server side bandwidth estimation?

yeah, by setting subscriber-bandwidth to 0 - unlimited

@davidzhao davidzhao merged commit b3b9881 into main Aug 14, 2023
@davidzhao davidzhao deleted the dz-simulate-bandwidth branch August 14, 2023 06:48
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants