Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missed event listeners on MediaStreamTrack #768

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

davidzhao
Copy link
Member

My previous attempt to consolidate setMediaStreamTrack missed the constructor case, so event listeners were missed the first run around.

@davidzhao davidzhao requested a review from lukasIO July 6, 2023 05:37
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

🦋 Changeset detected

Latest commit: 7394020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 85.25 KB (+0.01% 🔺)
dist/livekit-client.umd.js 90.21 KB (+0.01% 🔺)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants