Add option for passing AudioContext as WebAudioOptions #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 090843f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Nov 1, 2022
| @@ -773,7 +773,7 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>) | |||
|
|
|||
| this.participants.clear(); | |||
| this.activeSpeakers = []; | |||
| if (this.audioContext) { | |||
| if (this.audioContext && typeof this.options.expWebAudioMix === 'boolean') { | |||
There was a problem hiding this comment.
would it be better to check for equality? this.audioContext !== this.options.expWebAudioMix
There was a problem hiding this comment.
I agree, the type check is there to ensure typescript doesn't complain as the expWebAudioMix can be either boolean or an object. I'll think a bit more about how to make this nicer in general. Even though we use the same pattern for adaptive stream settings, it might make more sense to change the possible values for expWebAudioMix
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* add audiocontext as webaudioOptions * create new audio ctxt if not provided * changeset
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* add audiocontext as webaudioOptions * create new audio ctxt if not provided * changeset
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 9, 2022
* add audiocontext as webaudioOptions * create new audio ctxt if not provided * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.