Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ice server from join response #467

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Update ice server from join response #467

merged 3 commits into from
Oct 10, 2022

Conversation

cnderrauber
Copy link
Contributor

When ice servers from join response changed while reconnected (fallback to tls relay), should use new ice servers to create peerconnection

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: fe45787

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cnderrauber cnderrauber merged commit 951a07c into main Oct 10, 2022
@cnderrauber cnderrauber deleted the tls branch October 10, 2022 12:26
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
@imredobos
Copy link

imredobos commented Oct 18, 2022

Hi @cnderrauber , @lukasIO , @davidzhao i feel like we are loosing the opportunity to set ice servers from client side with this change. I do not want to rely on Livekit's embedded nor configured TURN, I want to handle it in a separate workflow and set it in the client side before create the peer connection. What idea do you have to achive this?

Update: the root issue could be that I want to use the embedded TURN functionality like an external one. If Livekit won't know about any TURN, it would not overwrite the pre configured ones.

max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
* Update ice server from join response
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
* Update ice server from join response
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 9, 2022
* Update ice server from join response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants