Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine preferred codec #262

Merged
merged 3 commits into from
Jun 10, 2022
Merged

refine preferred codec #262

merged 3 commits into from
Jun 10, 2022

Conversation

cnderrauber
Copy link
Contributor

No description provided.

@cnderrauber cnderrauber requested review from davidzhao and lukasIO June 10, 2022 03:35
@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

🦋 Changeset detected

Latest commit: 1a4806f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/room/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. can you also add a yarn changeset comment describing the change? it'll make generating a changelog easier

@cnderrauber
Copy link
Contributor Author

cnderrauber commented Jun 10, 2022

Looks good. can you also add a yarn changeset comment describing the change? it'll make generating a changelog easier

Done

@cnderrauber cnderrauber merged commit 879392c into main Jun 10, 2022
@cnderrauber cnderrauber deleted the codec branch June 10, 2022 04:49
@cnderrauber cnderrauber changed the title add browser name; refine preferred codec refine preferred codec Jun 10, 2022
@github-actions github-actions bot mentioned this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants