-
Notifications
You must be signed in to change notification settings - Fork 247
Update docs to clarify other client HKDF support #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ffb628d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughDocumentation-only changes: added a changeset for Changes
Sequence Diagram(s)(Skipped — changes are documentation-only and do not introduce new multi-component control flow.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✏️ Tip: You can disable this entire section by setting Comment |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.changeset/slow-dingos-look.md:
- Line 5: Fix the typo in the changelog sentence that reads "client client HKDF
support" by removing the duplicated word so it reads "client HKDF support";
locate the phrase "client client HKDF support" in the
.changeset/slow-dingos-look.md content and update it to "client HKDF support".
In `@src/e2ee/KeyProvider.ts`:
- Around line 94-97: Update the JSDoc in KeyProvider.ts to fix minor text
consistency: change "Array buffer" to "ArrayBuffer" and "client sdks" to "client
SDKs" in the comment block above the relevant KeyProvider methods (look for the
comment mentioning PBKDF2 and HKDF within the KeyProvider class or functions
that accept string vs ArrayBuffer keys) so the terminology matches the
TypeScript types and standard acronym capitalization.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/slow-dingos-look.mdsrc/e2ee/KeyProvider.ts
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
xianshijing-lk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits
Updates the
setKeyfunction docs to make it clear that HKDF isn't supported by other client sdk platforms.Closes #1791
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.