Ensure maxFps applies for very low framerates #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b320da3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
changed the title
size-limit report 📦
|
davidliu
reviewed
Jan 6, 2025
| // ensure that the sourceFramerate is the highest framerate applied across all layers so that the | ||
| // original encoding doesn't get bumped unintentionally by any of the other layers | ||
| const maxFramerate = | ||
| sourceFramerate && preset.encoding.maxFramerate |
There was a problem hiding this comment.
Is it possible for just one of the values to exist?
There was a problem hiding this comment.
Yeah, I think so.
If only one of them exists there should be no need to consider the sourceFramerate
davidliu
approved these changes
Jan 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.