Skip to content

Use capturing mediastreamtrack settings for audio feature detection #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 19, 2024

previously the processed track (if a processor is set) was used to determine active features. This doesn't reflect the actual settings on the capturing device though, so it makes more sense to query the settings directly from the input device's track.

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 89fbb45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from boks1971 November 19, 2024 07:49
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 85.68 KB (+0.03% 🔺)
dist/livekit-client.umd.js 91.77 KB (+0.03% 🔺)

@lukasIO lukasIO merged commit 7b037b8 into main Nov 19, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/source-settigns branch November 19, 2024 07:54
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants