Remove internal calls to setCodecPreferences on sender transceivers #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8181050 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
boks1971
approved these changes
Apr 23, 2024
lukasIO
changed the title
lukasIO
changed the title
not that I'm aware of, selecting a preferred codec client side will still work, but merely by signalling the preferred codec to the server instead of trying to set it on the transceiver. |
davidzhao
approved these changes
Apr 24, 2024
…sdk-js into lukas/remove-setcodepref
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recent issues with Chrome 124 arose, we remove all calls to
setCodecPreferenceson publish transceivers and let the server dictate the selected codec by order hierarchy.This is in accordance with the spec, as
setCodecPreferencesis meant to be a receiver only setting, see here