Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Extensible Checkers #1102

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

cscherban
Copy link
Contributor

@cscherban cscherban commented Apr 4, 2024

Pass options into ConnectionCheck and allow implentation of Checker by external packages

My use-case here is that I wanted to use the connection checker to run against known room connection configurations.

In this process, I also wanted to test publishing without running a getMedia, which required extending the Checker abstract class, which is currently not exported by the package

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 4f7ee64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2024

CLA assistant check
All committers have signed the CLA.

@cscherban cscherban changed the title Pass options into ConnectionCheck and allow implentation of Checker b… More Extensible Checkers Apr 4, 2024
@lukasIO
Copy link
Contributor

lukasIO commented Apr 4, 2024

lgtm, could you sign the CLA so that we can merge this in?

@cscherban
Copy link
Contributor Author

Is there a good way for me to test this locally prior to merge?

@lukasIO
Copy link
Contributor

lukasIO commented Apr 4, 2024

you can directly link the package locally to a project consuming it.
assuming you use pnpm, the most robust would be to

  1. pnpm build the livekit client packages
  2. set pnpm: { overrides: { livekit-client: link:./relative/path/to/client-sdk-js } } in the package.json and install with pnpm install

@lukasIO lukasIO merged commit 2fd950d into livekit:main Apr 17, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants