Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android automatic track management #23

Merged
merged 4 commits into from
Nov 11, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

buildscript {
ext {
compose_version = '1.0.4'
compose_version = '1.0.5'
kotlin_version = '1.5.31'
java_version = JavaVersion.VERSION_1_8
dokka_version = '1.5.0'
Expand Down
1 change: 1 addition & 0 deletions livekit-android-sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ dependencies {
implementation "androidx.core:core:${versions.androidx_core}"
implementation "com.google.protobuf:protobuf-java:${versions.protobuf}"
implementation "com.google.protobuf:protobuf-java-util:${versions.protobuf}"
implementation "androidx.compose.ui:ui:$compose_version"

implementation 'com.google.dagger:dagger:2.38'
kapt 'com.google.dagger:dagger-compiler:2.38'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,18 @@ import org.webrtc.PeerConnection


data class ConnectOptions(
/** Auto subscribe to room tracks upon connect, defaults to true */
val autoSubscribe: Boolean = true,
/**
* Automatically manage quality of subscribed video tracks, subscribe to the
* an appropriate resolution based on the size of the video elements that tracks
* are attached to.
*
* Also observes the visibility of attached tracks and pauses receiving data
* if they are not visible.
*/
val autoManageVideo: Boolean = false,

val iceServers: List<PeerConnection.IceServer>? = null,
val rtcConfig: PeerConnection.RTCConfiguration? = null,
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class LiveKit {
options?.videoTrackPublishDefaults?.let {
room.localParticipant.videoTrackPublishDefaults = it
}
room.autoManageVideo = options?.autoManageVideo ?: false

if (options?.audio == true) {
val audioTrack = room.localParticipant.createAudioTrack()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package io.livekit.android.events

import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.collect

class BroadcastEventBus<T> : EventListenable<T> {
private val mutableEvents = MutableSharedFlow<T>()
override val events = mutableEvents.asSharedFlow()

suspend fun postEvent(event: T) {
mutableEvents.emit(event)
}

suspend fun postEvents(eventsToPost: Collection<T>) {
eventsToPost.forEach { event ->
mutableEvents.emit(event)
}
}

fun readOnly(): EventListenable<T> = this
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package io.livekit.android.events

sealed class Event
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package io.livekit.android.events

import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.collect

interface EventListenable<out T> {
val events: SharedFlow<T>
}

suspend inline fun <T> EventListenable<T>.collect(crossinline action: suspend (value: T) -> Unit) {
return events.collect(action)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package io.livekit.android.events

import io.livekit.android.room.track.Track

sealed class TrackEvent : Event() {
class VisibilityChanged(val isVisible: Boolean) : TrackEvent()
class VideoDimensionsChanged(val newDimensions: Track.Dimensions) : TrackEvent()
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
import io.livekit.android.ConnectOptions
import io.livekit.android.Version
import io.livekit.android.dagger.InjectionNames
import io.livekit.android.renderer.TextureViewRenderer
import io.livekit.android.room.participant.*
import io.livekit.android.room.track.*
import io.livekit.android.util.LKLog
import kotlinx.coroutines.CoroutineDispatcher
import livekit.LivekitModels
import livekit.LivekitRtc
import org.webrtc.*
import javax.inject.Named

class Room
@AssistedInject
Expand All @@ -26,6 +29,8 @@ constructor(
private val eglBase: EglBase,
private val localParticipantFactory: LocalParticipant.Factory,
private val defaultsManager: DefaultsManager,
@Named(InjectionNames.DISPATCHER_IO)
private val ioDispatcher: CoroutineDispatcher,
) : RTCEngine.Listener, ParticipantListener, ConnectivityManager.NetworkCallback() {
init {
engine.listener = this
Expand All @@ -52,6 +57,7 @@ constructor(
var metadata: String? = null
private set

var autoManageVideo: Boolean = false
var audioTrackCaptureDefaults: LocalAudioTrackOptions by defaultsManager::audioTrackCaptureDefaults
var audioTrackPublishDefaults: AudioTrackPublishDefaults by defaultsManager::audioTrackPublishDefaults
var videoTrackCaptureDefaults: LocalVideoTrackOptions by defaultsManager::videoTrackCaptureDefaults
Expand Down Expand Up @@ -121,9 +127,9 @@ constructor(
}

participant = if (info != null) {
RemoteParticipant(engine.client, info)
RemoteParticipant(info, engine.client, ioDispatcher)
} else {
RemoteParticipant(engine.client, sid, null)
RemoteParticipant(sid, null, engine.client, ioDispatcher)
}
participant.internalListener = this
mutableRemoteParticipants[sid] = participant
Expand Down Expand Up @@ -282,7 +288,7 @@ constructor(
trackSid = track.id()
}
val participant = getOrCreateRemoteParticipant(participantSid)
participant.addSubscribedMediaTrack(track, trackSid!!)
participant.addSubscribedMediaTrack(track, trackSid!!, autoManageVideo)
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ import org.webrtc.PeerConnection
import org.webrtc.SessionDescription
import javax.inject.Inject
import javax.inject.Named
import javax.inject.Singleton
import kotlin.coroutines.Continuation
import kotlin.coroutines.suspendCoroutine

/**
* SignalClient to LiveKit WS servers
* @suppress
*/
@Singleton
class SignalClient
@Inject
constructor(
Expand Down Expand Up @@ -288,11 +290,26 @@ constructor(
sendRequest(request)
}

fun sendUpdateTrackSettings(sid: String, disabled: Boolean, videoQuality: LivekitRtc.VideoQuality) {
fun sendUpdateTrackSettings(
sid: String,
disabled: Boolean,
videoDimensions: Track.Dimensions?,
videoQuality: LivekitRtc.VideoQuality?,
) {
val trackSettings = LivekitRtc.UpdateTrackSettings.newBuilder()
.addTrackSids(sid)
.setDisabled(disabled)
.setQuality(videoQuality)
.apply {
if(videoDimensions != null) {
width = videoDimensions.width
height = videoDimensions.height
} else if(videoQuality != null) {
quality = videoQuality
} else {
// default to HIGH
quality = LivekitRtc.VideoQuality.HIGH
}
}

val request = LivekitRtc.SignalRequest.newBuilder()
.setTrackSetting(trackSettings)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import io.livekit.android.room.SignalClient
import io.livekit.android.room.track.*
import io.livekit.android.util.CloseableCoroutineScope
import io.livekit.android.util.LKLog
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
Expand All @@ -13,14 +14,24 @@ import org.webrtc.MediaStreamTrack
import org.webrtc.VideoTrack

class RemoteParticipant(
val signalClient: SignalClient,
sid: String,
identity: String? = null,
val signalClient: SignalClient,
private val ioDispatcher: CoroutineDispatcher,
) : Participant(sid, identity) {
/**
* @suppress
*/
constructor(signalClient: SignalClient, info: LivekitModels.ParticipantInfo) : this(signalClient, info.sid, info.identity) {
constructor(
info: LivekitModels.ParticipantInfo,
signalClient: SignalClient,
ioDispatcher: CoroutineDispatcher
) : this(
info.sid,
info.identity,
signalClient,
ioDispatcher,
) {
updateFromInfo(info)
}

Expand All @@ -43,7 +54,11 @@ class RemoteParticipant(
var publication = getTrackPublication(trackSid)

if (publication == null) {
publication = RemoteTrackPublication(trackInfo, participant = this)
publication = RemoteTrackPublication(
trackInfo,
participant = this,
ioDispatcher = ioDispatcher
)

newTrackPublications[trackSid] = publication
addTrackPublication(publication)
Expand Down Expand Up @@ -71,11 +86,21 @@ class RemoteParticipant(
/**
* @suppress
*/
fun addSubscribedMediaTrack(mediaTrack: MediaStreamTrack, sid: String, triesLeft: Int = 20) {
fun addSubscribedMediaTrack(
mediaTrack: MediaStreamTrack,
sid: String,
autoManageVideo: Boolean = false,
triesLeft: Int = 20
) {
val publication = getTrackPublication(sid)
val track: Track = when (val kind = mediaTrack.kind()) {
KIND_AUDIO -> AudioTrack(rtcTrack = mediaTrack as AudioTrack, name = "")
KIND_VIDEO -> VideoTrack(rtcTrack = mediaTrack as VideoTrack, name = "")
KIND_VIDEO -> RemoteVideoTrack(
rtcTrack = mediaTrack as VideoTrack,
name = "",
autoManageVideo = autoManageVideo,
dispatcher = ioDispatcher
)
else -> throw TrackException.InvalidTrackTypeException("invalid track type: $kind")
}

Expand All @@ -90,7 +115,7 @@ class RemoteParticipant(
} else {
coroutineScope.launch {
delay(150)
addSubscribedMediaTrack(mediaTrack, sid, triesLeft - 1)
addSubscribedMediaTrack(mediaTrack, sid, autoManageVideo, triesLeft - 1)
}
}
return
Expand Down
Loading