android automatic track management #23
Conversation
| @@ -1,5 +1,8 @@ | |||
| package io.livekit.android.room.track | |||
|
|
|||
| import io.livekit.android.events.BroadcastEventBus | |||
| import io.livekit.android.events.EventListenable | |||
There was a problem hiding this comment.
looks like this one can be cleaned up, good eye.
| val lastSize = size() | ||
| lastCoordinates = layoutCoordinates | ||
|
|
||
| if (lastVisible != isVisible() || lastSize != size()) { |
There was a problem hiding this comment.
Need some Kotlin education :-) or a new pair of glasses :-)
A couple of lines above these variables (lastVisible and lastSize) are set to return values from the functions checked against here. Under what conditions will those be not equal?
There was a problem hiding this comment.
the underlying calculations of isVisible and size depend on the lastCoordinates, which gets updated in line 50. They'll be different if the new coordinates are different from the old coordinates.
|
|
||
| override fun onGlobalLayout() { | ||
| handler.removeCallbacksAndMessages(null) | ||
| handler.postDelayed({ |
There was a problem hiding this comment.
will this be debouncing the calls? or would it simply queue them up? we'd want a debounced behavior
also, when elements become visible, we should notify immediately to minimize delay of having no content showing. the delay should only be applied to when things are moving to invisible.
No description provided.