-
Notifications
You must be signed in to change notification settings - Fork 193
multi stream websocket connection for ElevenLabs TTS #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a4c1eff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
LG!! please review it sir @toubatbrian :) |
| } | ||
|
|
||
| return [timedWords, text.substring(end)]; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG !!
|
There are still some issues with ending the websocket manager. Right now I'm not even sure if we can actually solve this with the current architecture, but let's see what else I can find out I'm experiencing similar issues with the current deepgram implementation (on stt side). |
|
Okay, I've currently not so much time to dig into it or fix it, but here are my current findings:
so what we need is either:
|
based on the work of @Devesh36
…uring STT/TTS Processing)
57a73d6 to
a4c1eff
Compare
|
this one would be ready @toubatbrian |
|
Thanks @simllll, will take a look! |
Description
Implements multi stream websocket connection for ElevenLabs TTS
Based on the work of #828
fix #824
Changes Made
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
not sure how to test the alignment part, but I followed the python implementation. We use the audio part of this implementation already in production.
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.