Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@lit-labs/eleventy-plugin-lit] Update readme to clarify using .cjs for eleventy config #2637

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

augustjk
Copy link
Member

Add to README that when using .cjs extension for the eleventy config file, it needs to be specified via command line argument for eleventy to pick up.

@augustjk augustjk requested a review from justinfagnani as a code owner March 15, 2022 17:28
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2022

🦋 Changeset detected

Latest commit: 9a18c36

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@augustjk augustjk requested review from aomarks and removed request for justinfagnani March 15, 2022 17:28
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +3% (-0.30ms - +0.96ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +2% (-1.10ms - +2.16ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-1.07ms - +0.95ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -11% - +5% (-1.49ms - +0.79ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +0% (-2.45ms - +0.30ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-1.14ms - +0.52ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +1% (-12.35ms - +9.00ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-2.54ms - +5.24ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +3% (-2.85ms - +10.55ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-3.05ms - +2.75ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-10.75ms - +11.02ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +2% (-7.04ms - +17.48ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-7.11ms - +13.43ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
101.58ms - 103.96ms-unsure 🔍
-1% - +2%
-1.10ms - +2.16ms
faster ✔
21% - 23%
27.09ms - 30.30ms
tip-of-tree
tip-of-tree
101.12ms - 103.35msunsure 🔍
-2% - +1%
-2.16ms - +1.10ms
-faster ✔
21% - 23%
27.68ms - 30.78ms
previous-release
previous-release
130.39ms - 132.54msslower ❌
26% - 30%
27.09ms - 30.30ms
slower ❌
27% - 30%
27.68ms - 30.78ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
943.33ms - 957.23ms-unsure 🔍
-1% - +1%
-12.35ms - +9.00ms
faster ✔
7% - 9%
67.74ms - 89.77ms
tip-of-tree
tip-of-tree
943.84ms - 960.06msunsure 🔍
-1% - +1%
-9.00ms - +12.35ms
-faster ✔
6% - 9%
65.30ms - 88.86ms
previous-release
previous-release
1020.49ms - 1037.58msslower ❌
7% - 9%
67.74ms - 89.77ms
slower ❌
7% - 9%
65.30ms - 88.86ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1039.16ms - 1057.81ms-unsure 🔍
-1% - +2%
-7.04ms - +17.48ms
faster ✔
3% - 5%
35.54ms - 59.01ms
tip-of-tree
tip-of-tree
1035.31ms - 1051.22msunsure 🔍
-2% - +1%
-17.48ms - +7.04ms
-faster ✔
4% - 6%
41.81ms - 63.18ms
previous-release
previous-release
1088.63ms - 1102.89msslower ❌
3% - 6%
35.54ms - 59.01ms
slower ❌
4% - 6%
41.81ms - 63.18ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
42.55ms - 44.03ms-unsure 🔍
-2% - +2%
-1.07ms - +0.95ms
faster ✔
10% - 15%
5.01ms - 7.28ms
tip-of-tree
tip-of-tree
42.67ms - 44.04msunsure 🔍
-2% - +2%
-0.95ms - +1.07ms
-faster ✔
10% - 14%
4.98ms - 7.18ms
previous-release
previous-release
48.58ms - 50.30msslower ❌
11% - 17%
5.01ms - 7.28ms
slower ❌
11% - 17%
4.98ms - 7.18ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
108.41ms - 115.55ms-unsure 🔍
-2% - +5%
-2.54ms - +5.24ms
faster ✔
0% - 7%
0.24ms - 8.39ms
tip-of-tree
tip-of-tree
109.09ms - 112.16msunsure 🔍
-5% - +2%
-5.24ms - +2.54ms
-faster ✔
3% - 7%
3.17ms - 8.15ms
previous-release
previous-release
114.33ms - 118.25msslower ❌
0% - 8%
0.24ms - 8.39ms
slower ❌
3% - 7%
3.17ms - 8.15ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.86ms - 34.92ms-unsure 🔍
-1% - +3%
-0.30ms - +0.96ms
faster ✔
6% - 10%
2.39ms - 3.76ms
tip-of-tree
tip-of-tree
33.72ms - 34.41msunsure 🔍
-3% - +1%
-0.96ms - +0.30ms
-faster ✔
8% - 10%
2.85ms - 3.96ms
previous-release
previous-release
37.04ms - 37.90msslower ❌
7% - 11%
2.39ms - 3.76ms
slower ❌
8% - 12%
2.85ms - 3.96ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.13ms - 13.93ms-unsure 🔍
-11% - +5%
-1.49ms - +0.79ms
faster ✔
9% - 19%
1.38ms - 3.04ms
tip-of-tree
tip-of-tree
12.81ms - 14.94msunsure 🔍
-6% - +11%
-0.79ms - +1.49ms
-faster ✔
4% - 20%
0.57ms - 3.15ms
previous-release
previous-release
15.01ms - 16.46msslower ❌
10% - 23%
1.38ms - 3.04ms
slower ❌
3% - 24%
0.57ms - 3.15ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
350.53ms - 361.22ms-unsure 🔍
-1% - +3%
-2.85ms - +10.55ms
faster ✔
31% - 33%
160.14ms - 174.16ms
tip-of-tree
tip-of-tree
347.98ms - 356.06msunsure 🔍
-3% - +1%
-10.55ms - +2.85ms
-faster ✔
32% - 34%
164.93ms - 177.07ms
previous-release
previous-release
518.50ms - 527.56msslower ❌
44% - 50%
160.14ms - 174.16ms
slower ❌
46% - 51%
164.93ms - 177.07ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.71ms - 69.45ms-unsure 🔍
-3% - +0%
-2.45ms - +0.30ms
faster ✔
14% - 17%
11.56ms - 14.37ms
tip-of-tree
tip-of-tree
68.59ms - 70.72msunsure 🔍
-0% - +4%
-0.30ms - +2.45ms
-faster ✔
13% - 16%
10.35ms - 13.42ms
previous-release
previous-release
80.44ms - 82.65msslower ❌
17% - 21%
11.56ms - 14.37ms
slower ❌
15% - 19%
10.35ms - 13.42ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
148.20ms - 151.75ms-unsure 🔍
-2% - +2%
-3.05ms - +2.75ms
faster ✔
11% - 14%
19.34ms - 24.37ms
tip-of-tree
tip-of-tree
147.83ms - 152.41msunsure 🔍
-2% - +2%
-2.75ms - +3.05ms
-faster ✔
11% - 14%
18.81ms - 24.61ms
previous-release
previous-release
170.05ms - 173.61msslower ❌
13% - 16%
19.34ms - 24.37ms
slower ❌
12% - 17%
18.81ms - 24.61ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
72.18ms - 73.28ms-unsure 🔍
-2% - +1%
-1.14ms - +0.52ms
unsure 🔍
-3% - +0%
-2.02ms - +0.02ms
tip-of-tree
tip-of-tree
72.42ms - 73.67msunsure 🔍
-1% - +2%
-0.52ms - +1.14ms
-unsure 🔍
-2% - +1%
-1.75ms - +0.38ms
previous-release
previous-release
72.87ms - 74.60msunsure 🔍
-0% - +3%
-0.02ms - +2.02ms
unsure 🔍
-1% - +2%
-0.38ms - +1.75ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
986.60ms - 1003.27ms-unsure 🔍
-1% - +1%
-10.75ms - +11.02ms
unsure 🔍
-1% - +1%
-9.05ms - +14.30ms
tip-of-tree
tip-of-tree
987.80ms - 1001.80msunsure 🔍
-1% - +1%
-11.02ms - +10.75ms
-unsure 🔍
-1% - +1%
-8.27ms - +13.25ms
previous-release
previous-release
984.14ms - 1000.49msunsure 🔍
-1% - +1%
-14.30ms - +9.05ms
unsure 🔍
-1% - +1%
-13.25ms - +8.27ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1091.35ms - 1107.81ms-unsure 🔍
-1% - +1%
-7.11ms - +13.43ms
unsure 🔍
-1% - +1%
-11.17ms - +11.33ms
tip-of-tree
tip-of-tree
1090.28ms - 1102.56msunsure 🔍
-1% - +1%
-13.43ms - +7.11ms
-unsure 🔍
-1% - +1%
-12.90ms - +6.74ms
previous-release
previous-release
1091.84ms - 1107.17msunsure 🔍
-1% - +1%
-11.33ms - +11.17ms
unsure 🔍
-1% - +1%
-6.74ms - +12.90ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@augustjk augustjk merged commit 3cff5a2 into main Mar 15, 2022
@augustjk augustjk deleted the 11ty-readme-update branch March 15, 2022 17:42
This was referenced Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants