Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno KV #12

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Deno KV #12

merged 7 commits into from
Jan 3, 2025

Conversation

lishaduck
Copy link
Owner

Add a Deno KV layer.

@lishaduck lishaduck added the enhancement New feature or request label Nov 27, 2024
@lishaduck lishaduck self-assigned this Nov 27, 2024
@lishaduck lishaduck enabled auto-merge November 27, 2024 03:53
@lishaduck lishaduck mentioned this pull request Nov 27, 2024
15 tasks
@lishaduck
Copy link
Owner Author

lishaduck commented Nov 27, 2024

I need to figure out how to pass --unstable-kv to the task runner. I used deno -A --unstable-kv ./node_modules/.bin/vitest run locally, but there's got to be a better way, right?

EDIT: Filed a discussion: denoland/deno#27120. I'm blocking this on getting a response for ~3ish days, then'll just merge the workaround.

@lishaduck lishaduck disabled auto-merge December 4, 2024 02:06
@pixeleet
Copy link
Contributor

pixeleet commented Jan 3, 2025

This looks good, we should merge it imho

@lishaduck
Copy link
Owner Author

lishaduck commented Jan 3, 2025

This looks good, we should merge it imho

Yeah, I agree, the code is good.
I think I just figured out a way to get unstable flags passed to tests, so, if it works, 👍 from me.

EDIT: CI passed 🥳

@lishaduck lishaduck merged commit bbc4544 into main Jan 3, 2025
1 check passed
@lishaduck lishaduck deleted the deno-kv branch January 3, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants