Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deno] Path to stabilization #1

Open
6 of 15 tasks
lishaduck opened this issue Nov 18, 2024 · 3 comments
Open
6 of 15 tasks

[Deno] Path to stabilization #1

lishaduck opened this issue Nov 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lishaduck
Copy link
Owner

lishaduck commented Nov 18, 2024

I plan on eventually PR'ing this to the main effect repo. Here's what I feel is needed first (TL;DR: Full Node compat):

Fill out DenoContext with Deno-native layers (Use of the Node compat layer is acceptable):

Fill out additional documented platform primitives:

Fill out HttpApi support:

  • HttpClient (fetch())
  • HttpServer (Deno.serve1)

Ensure support for important2 ecosystem packages:

  • CLI (Just needs DenoContext?)
  • RPC (Needs HttpServer)

Later:

  • I haven't looked closely, but Permissions would probably be good to implement?
  • Deno is adding otel, we should investigate integrating it

Footnotes

  1. Should figure out how to support "declarative fetch"/deno serve via toWebHandler

  2. Read "packages I want to use, but would rather wait for Deno support first."

@lishaduck lishaduck added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 18, 2024
@lishaduck lishaduck self-assigned this Nov 18, 2024
@lishaduck lishaduck moved this from Todo to In Progress in @lishaduck's todo list Nov 18, 2024
@lishaduck
Copy link
Owner Author

Current status: DenoContext is almost done. I'm copying over the tests from the Node platform, finding bugs, fixing them, and repeating. Then, I'll just have DenoTerminal before I've finished milestone 1.

@lishaduck lishaduck changed the title Path to stabilization [Deno] Path to stabilization Dec 5, 2024
@nounder
Copy link

nounder commented Dec 7, 2024

@lishaduck How is work in HTTP area? I'd like to help there.

@lishaduck
Copy link
Owner Author

@lishaduck How is work in HTTP area? I'd like to help there.

I've been busy with school and AoC for the last week, so I haven't gotten around to finishing work in KV; even then, I was planning on filling out the Terminal API and finishing up CommandExecutor first: in other words: work in http is lacking.
Feel free to send in a PR! I'd recommend trying to port HttpClient from effect-platform-browser. Speaking of which, I need to update the license to attribute Effectful Technologies...

Also, is there anything I can do to support effect-deno? I didn't look closely, but it looks like compat patches, so if there's anything I can do to help support it from over here, I'm happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants