Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Deno-native file system module #2

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add a Deno-native file system module #2

merged 3 commits into from
Nov 25, 2024

Conversation

lishaduck
Copy link
Owner

Well... it's mostly Deno-native, but Deno 2 removed FileDescriptors in favor of the OOP Deno.FsFile API, so I used a bit of Node-compat. Long-term, @effect/platform should probably drop using fids, but for now, I just want to get this to the finish line
Still needs tests, otherwise complete.

@lishaduck lishaduck added the enhancement New feature or request label Nov 18, 2024
@lishaduck lishaduck self-assigned this Nov 18, 2024
@lishaduck lishaduck mentioned this pull request Nov 18, 2024
15 tasks
@lishaduck lishaduck marked this pull request as draft November 18, 2024 02:55
@lishaduck lishaduck force-pushed the fs branch 4 times, most recently from 59ba6d7 to fb0b1c7 Compare November 20, 2024 14:49
@lishaduck lishaduck marked this pull request as ready for review November 21, 2024 01:38
@lishaduck
Copy link
Owner Author

lishaduck commented Nov 21, 2024

Status update: readAlloc doesn't work most of the time, but I can repro the bugs in the repl, and there are a few existing issues in the deno repository about how the node-compat layer for NFS.read doesn't always work right with fids, so 🤷‍♂️
I plan on merging this tomorrow after adding some more docs.

5.7 includes some breaking fixes that Deno isn't pulling in until 2.2.
@lishaduck lishaduck merged commit 3b6fe66 into main Nov 25, 2024
1 check passed
@lishaduck lishaduck deleted the fs branch November 25, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant